secretkeylabs / xverse-core

Core library for Xverse wallet

Other

39 stars 19 forks source link

fix bitwise ops #342

Closed victorkirov closed 10 months ago

victorkirov commented 10 months ago

🔘 PR Type

What kind of change does this PR introduce?

[x] Bugfix

📜 Background

SigHash calcs were incorrect due to using bitwise OR instead of AND, resulting in the wrong data being shown on the extension PSBT signing screen.

🔄 Changes

Does this PR introduce a breaking change?

[ ] Yes, Incompatible API changes
[ ] No, Adds functionality (backwards compatible)
[x] No, Bug fixes (backwards compatible)

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 10 months ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@7.2.0-b73af64