Remove assumptions that inputs and outputs must have positive amount …

[victorkirov]

…values

🔘 PR Type

What kind of change does this PR introduce?

• [x] Bugfix

📜 Background

There was a check to ensure all inputs and outputs had a positive value, but that is not necessarily the case when you have a script output or dummy inputs/outputs on a non-sighash-all txn.

🔄 Changes

Does this PR introduce a breaking change?

• [ ] Yes, Incompatible API changes
• [ ] No, Adds functionality (backwards compatible)
• [x] No, Bug fixes (backwards compatible)

Changes:

• Remove the check on the amount field for inputs and outputs

✅ Review checklist

Please ensure the following are true before merging:

• [ ] Code Style is consistent with the project guidelines.
• [ ] Code is readable and well-commented.
• [ ] No unnecessary or debugging code has been added.
• [ ] Security considerations have been taken into account.
• [ ] The change has been manually tested and works as expected.
• [ ] Breaking changes and their impacts have been considered and documented.
• [ ] Code does not introduce new technical debt or issues.

[github-actions[bot]]

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@8.0.0-c94b35d