secretkeylabs / xverse-core

Core library for Xverse wallet
Other
39 stars 19 forks source link

Update the RbfTransaction class constructor #348

Closed dhriaznov closed 10 months ago

dhriaznov commented 10 months ago

🔘 PR Type

What kind of change does this PR introduce?

📜 Background

We use the getSeedPhrase function to sign the transaction, so there is no need to ask for it in the RbfTransaction constructor, it would make more sense to pass it to the signing function. Also, this change would enable a better UX for the mobile app since we won't need to ask the user to enter a password when they just enter the Speed Up tx screen, instead, they'll have to enter the password only when they sign the RBF tx.

Issue Link: #[ENG-3379] Context Link (if applicable):

🔄 Changes

Does this PR introduce a breaking change?

Changes:

Impact:

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 10 months ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@8.0.1-55cc6d2