secretkeylabs / xverse-core

Core library for Xverse wallet

Other

39 stars 19 forks source link

chore: improve deploy checks and add lim and dec params to the return value #359

Closed fedeerbes closed 10 months ago

fedeerbes commented 10 months ago

🔘 PR Type

[x] Refactoring (no functional changes, no api changes)

📜 Background

Fix dec prop check in deploy operation and add lim and dec to the return value

🔄 Changes

Does this PR introduce a breaking change?

[ ] Yes, Incompatible API changes
[x] No, Adds functionality (backwards compatible)
[ ] No, Bug fixes (backwards compatible)

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 10 months ago

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@9.1.0-f653e71