secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

ENG-2696: Fix restore seed phrase screen scroll #700

Closed jordankzf closed 10 months ago

jordankzf commented 12 months ago

🔘 PR Type

What kind of change does this PR introduce?

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[issue_number] Context Link (if applicable):

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

jordankzf commented 11 months ago

Fixed @DuskaT021's reported issue. Thanks!

teebszet commented 10 months ago

@jordankzf even though this is a minor UI fix, when you touch the css/layout which is shared across many screens, it requires a thorough check that nothing was broken.

in this case, it's a good idea to at least include screenshots or video of the affected layouts behaving as expected compared to production

jordankzf commented 10 months ago
image

Ledger layout unaffected

image image

Collectibles layout unaffected

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7485577823