secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

fix: cap stx contract call fees #722

Closed teebszet closed 11 months ago

teebszet commented 11 months ago

πŸ”˜ PR Type

What kind of change does this PR introduce?

πŸ“œ Background

stackerDAO reported really high fees when stacking via their dapp here: https://app.stackingdao.com/stack

we are taking fee estimates from the hiro endpoint https://api.hiro.so/v2/fees/transaction, but the endpoint currently responds with really high estimates (~50STX).

this PR will set the fee capped at the threshold determined from our xverse-api (currently 1STX)

depends on: https://github.com/secretkeylabs/xverse-core/pull/324

πŸ”„ Changes

Impact:

πŸ–Ό Screenshot / πŸ“Ή Video

image

βœ… Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 11 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7263246195