secretkeylabs / xverse-web-extension

Other
46 stars 24 forks source link

[ENG-3036] feat: Rename accounts from the change account screen #740

Closed dhriaznov closed 8 months ago

dhriaznov commented 8 months ago

πŸ”˜ PR Type

What kind of change does this PR introduce?

πŸ“œ Background

As an Xverse user I want to see rename my accounts after I’ve selected them So that I can identify them easily when selecting & switching accounts

Issue Link: #[ENG-3036] Context Link (if applicable):

πŸ”„ Changes

Impact:

πŸ–Ό Screenshot / πŸ“Ή Video

Videos are in the linear ticket.

βœ… Review checklist

Please ensure the following are true before merging:

dhriaznov commented 8 months ago

Thanks for the review folks, I updated the PR, feel free to take a second look πŸ™Œ

dhriaznov commented 8 months ago

I just resolved the git conflicts, could you approve again pls? @fedeerbes

github-actions[bot] commented 8 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7630950545

dhriaznov commented 8 months ago

Fixed the issue DuΕ‘ana found, @fedeerbes could you please review?

DuskaT021 commented 8 months ago

tested can be merged πŸ‘Œ