secretkeylabs / xverse-web-extension

Other

46 stars 25 forks source link

Fix indent on the Settings screen #754

Closed dhriaznov closed 10 months ago

dhriaznov commented 10 months ago

🔘 PR Type

What kind of change does this PR introduce?

[x] Bugfix

📜 Background

I noticed that we have too wide a vertical indent between the items and the arrow icon is not vertically centered for each of the items, this UI issue is only present on web-extension, and looks good on mobile. This PR aims to fix this UI issue.

Issue Link: #[ENG-3572] Context Link (if applicable):

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

Explain the broader impact of these changes.
How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

settings Monosnap Monosnap 2024-01-12 21-39-09

settings 2Monosnap Monosnap 2024-01-12 21-39-19

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7507314919

teebszet commented 10 months ago

padding and margin fixes only, let's merge this one