secretkeylabs / xverse-web-extension

Other

46 stars 24 forks source link

[ENG-3571] fix: rare sats icon shape and remove extra props from rare sat icon component #755

Closed fedeerbes closed 8 months ago

fedeerbes commented 8 months ago

🔘 PR Type

Bugfix

📜 Background

This PR fixes the shape of some of the rare sats icons and removes unused props from rare sat icon component

Issue Link: #ENG-3571

🔄 Changes

use re exported assets for rare sat icons
remove unused props from rare sat icon component
remove unused rareSatAsset component

Impact:

Every flow where we show a rare sat icon, but checking the list of supported rarity is enough to see if everything it's ok

🖼 Screenshot / 📹 Video

BEFORE	AFTER

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 8 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7532807105

teebszet commented 8 months ago

amazing work 😍

DuskaT021 commented 8 months ago

tested and can be merged