secretkeylabs / xverse-web-extension

Other

46 stars 25 forks source link

[ENG-3587] chore: use new core version with btc signer version upgrade #763

Closed fedeerbes closed 10 months ago

fedeerbes commented 10 months ago

🔘 PR Type

[ ] Other... Please describe: btc signer test upgrade

📜 Background

https://linear.app/xverseapp/issue/ENG-3587/upgrade-scurebtc-signer-to-121-on-all-platforms

Use this PR to test the upgrade version of btc signer and fix the breaking change on RBF txs

🖼 Screenshot / 📹 Video

https://github.com/secretkeylabs/xverse-web-extension/assets/18606335/c38bda7f-0f4d-4ceb-a20e-d8cbd5385940

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

teebszet commented 10 months ago

@fedeerbes looks like this one needs the to account for the breaking change in core

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7609585483