secretkeylabs / xverse-web-extension

Other
46 stars 25 forks source link

fix: Revert getBrc20Tokens to sequential call #769

Closed jordankzf closed 10 months ago

jordankzf commented 10 months ago

🔘 PR Type

What kind of change does this PR introduce?

On a newly restored wallet, brcCoinsList will not be populated. As a such, the previous concurrent API calls will not be aware of owned ordinals which will cause no fiat value to be displayed for brc20 tokens. This PR will revert the concurrent calls to a sequential order, which has a slight speed impact, but will ensure that the fiat value will always be displayed.

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[issue_number] Context Link (if applicable):

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7649852927