secretkeylabs / xverse-web-extension

Other

46 stars 25 forks source link

Option to select xverse as default browser wallet in settings #774

Closed victorkirov closed 10 months ago

victorkirov commented 10 months ago

🔘 PR Type

What kind of change does this PR introduce?

[x] Enhancement

📜 Background

When a user connects to an extension wallet, if there are multiple wallets implementing the sats connect interface, then the last wallet loaded would get all event messages. A user may want to force Xverse as the priority wallet to intercept these messages if the app using sats connect is using the default providers.

🔄 Changes

This adds a new setting toggle to set Xverse as the priority sats-connect wallet.

Note that the setting is stored in chrome storage so that it's available from the content-script directly without having to send messages around.

🖼 Screenshot / 📹 Video

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 10 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7738374490

DuskaT021 commented 10 months ago

@m-aboelenein merged before it was tested!

m-aboelenein commented 10 months ago

@m-aboelenein merged before it was tested!

I tested this one, and the change is pretty minimal we can retest with the RC