secretkeylabs / xverse-web-extension

Other
46 stars 24 forks source link

Ensure correct ordinal is shown in ordinal detail view #779

Closed victorkirov closed 8 months ago

victorkirov commented 8 months ago

🔘 PR Type

What kind of change does this PR introduce?

📜 Background

This is a quick fix and first step to removing the selected NFT reducer. It ensures that the ordinal detail screen only shows the ordinal that the user selected.

🔄 Changes

Adds a check to ensure that the prepopulated ordinal data matches the selected ordinal.

To test:

  1. Open the gallery page
  2. Click on a collection
  3. Click on an ordinal within the collection
  4. Go back to the home screen from the bottom menu
  5. Go to the gallery view
  6. Click on a different ordinal that is not part of a collection

The current prod version would show the first ordinal selected instead of the one you want to view. The new version will show the correct one.

✅ Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 8 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7666183646