secretkeylabs / xverse-web-extension

Other

46 stars 24 forks source link

fix: reset balance state between change accounts #783

Closed teebszet closed 8 months ago

teebszet commented 8 months ago

🔘 PR Type

[x] Bugfix

📜 Background

https://linear.app/xverseapp/issue/ENG-3674/balance-issue-in-ledger-account-on-v029-rc-sum-doesnt-match-assets

🔄 Changes

reset all balances state in store, when switching accounts

Impact:

Explain the broader impact of these changes.
How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

before:

after

https://github.com/secretkeylabs/xverse-web-extension/assets/6109710/d5f1bdfe-3117-4f84-8981-79abc2f58422

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

DuskaT021 commented 8 months ago

tested can be merged