secretkeylabs / xverse-web-extension

Other

40 stars 19 forks source link

replace deprecated util with core #786

Closed m-aboelenein closed 5 months ago

m-aboelenein commented 5 months ago

🔘 PR Type

What kind of change does this PR introduce?

[x] Code style update (formatting, local variables)

📜 Background

Using the newly exported getAppIconFromWebManifest from core

🖼 Screenshot / 📹 Video

Screenshot 2024-02-02 at 9 14 09 AM

✅ Review checklist

Please ensure the following are true before merging:

[ ] Code Style is consistent with the project guidelines.
[ ] Code is readable and well-commented.
[ ] No unnecessary or debugging code has been added.
[ ] Security considerations have been taken into account.
[ ] The change has been manually tested and works as expected.
[ ] Breaking changes and their impacts have been considered and documented.
[ ] Code does not introduce new technical debt or issues.

github-actions[bot] commented 5 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7752658884

teebszet commented 5 months ago

@DuskaT021 I'll test this one. it's a minor change