secretkeylabs / xverse-web-extension

Other
46 stars 24 forks source link

[ENG-3193] refactor: Refactor away from selectedSatBundle #793

Closed terencehh closed 6 months ago

terencehh commented 8 months ago

πŸ”˜ PR Type

What kind of change does this PR introduce?

To be merged after #791.

πŸ“œ Background

This PR directly extends off the previous PR, implementing additional state management fixes to selectedSatBundle.

context: when on multiple tabs (bundle data will overwrite the previous data on the old tab). This PR introduces a fix by removing state management for selectedSatBundle by supplying a output (txid+vout) to the rare-sats-bundle route, and calling react-query-hooks (with caching) to retrieve bundle data instead of relying on state management.

Issue Link: ENG-3193 Context Link (if applicable):

πŸ”„ Changes

Impact:

πŸ–Ό Screenshot / πŸ“Ή Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

βœ… Review checklist

Please ensure the following are true before merging:

github-actions[bot] commented 8 months ago

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7809871141