secretkeylabs / xverse-web-extension

Other
46 stars 23 forks source link

XVerse Chrome Extension doesn't allow custom URLs for custom networks #836

Open Warchant opened 2 months ago

Warchant commented 2 months ago

Component

XVerse Chrome Web Extension.

Severity

Minor.

Summary

I want to use XVerse for testing purposes on my custom signet network. XVerse allows selection of Mainnet, Testnet and Signet networks, but all of those are "pre-deployed" networks. I want to use my own custom network.

I successfully started bitcoind with my custom signet, started mempool, ensured correct configuration and made sure my mempool API is available over HTTPS.

But when I open XVerse Chrome Extension, I select "Signet" network, then paste url of my mempool API, it keeps showing me "Invalid URL" error.

I traced that to this code: https://github.com/secretkeylabs/xverse-web-extension/blob/7c5a8e7efec5107404fb4e17159fca7db2e44d3d/src/app/utils/helper.ts#L159-L178

Here, xverse fetches hash of a 1st block from 2 sources: from default url, and from a custom url that user provided.

If hashes are different, XVerse Chrome Extensionshows "Invalid URL" error.

But hashes are expected to be different, because I am using my own custom signet network.

Expected Fix

Please add a bypass for this check (maybe a checkbox?), such that XVerse Chrome Extension will "just accept" my whatever custom URL is provided.

This will add a support for custom signet networks. Thank you.

Warchant commented 2 months ago

cc @abdulhaseeb4239 @victorkirov

yknl commented 2 months ago

Thanks for reporting, a fix is being implemented.

taras-ostapovych-boostylabs commented 2 months ago

like to this request

bap2pecs commented 2 months ago

Thanks for reporting, a fix is being implemented.

is there a branch/issue we can track? we also need to connect to our local Bitcoin regtest network

Warchant commented 1 month ago

Any progress?