search

secretpizzaparty / shopify-connect-for-woocommerce

Shopify Connect for WooCommerce Plugin
https://secretpizza.party
GNU General Public License v2.0
10 stars 2 forks source link

Not finding my shopify shop name, redirects to embeds.shopify.com instead #24

Closed websitedeptuk closed 8 years ago

websitedeptuk commented 8 years ago

On activating your plugin, I found that it redirects to "embeds.myshopify.com", which is an empty sample store, not my Shopify store.

"Embeds" seems to be the backup you have specified in case the plugin can't find the store that the official Shopify plugin uses?

I manually changed the 'secp_shop' field in my database, and this seems to have resolved it for me.

nickhamze commented 8 years ago

This pesky bug again. I thought we'd finally fixed it. Any ideas @jkudish ?

jkudish commented 8 years ago

@websitedepuk where exactly did you see embeds as the url/redirect?

That's the default that the shopify plugin sets (not in our control) but our plugin should ignore it for redirect purposes. It's possible we missed a spot.

Let me know!

websitedeptuk commented 8 years ago

In shopify-connect.php, on line 113, I can see 'embeds.shopify.com'.

jkudish commented 8 years ago

Yep that's where we ignore it...

Can you help me out by letting me know where you saw the redirect please?

On Wed, Aug 24, 2016, 1:33 AM Website Department notifications@github.com wrote:

In shopify-connect.php, on line 113, I can see 'embeds.shopify.com'.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/secretpizzaparty/shopify-connect-for-woocommerce/issues/24#issuecomment-241994386, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP4nRNdXOaMwhd_V8QVutlAT_GR_PKjks5qjAHigaJpZM4JrEwy .

websitedeptuk commented 8 years ago

The problem occurred when I clicked on Woocommerce in the left menu bar and that took me straight to embeds.shopify.com.

I don't know if this helps, but in terms of plugin installation, initially, I installed and activated the Shopify plugin. Then I deactivated that and installed and activated the Woocommerce plugin.

When I discovered your plugin to connect the two I installed and activated it, but it told me that I needed both Woocommerce and Shopify plugins active. I reactivated the Shopify plugin and then activated your plugin.

jkudish commented 8 years ago

Okay thanks. I'll look into it!

On Thu, Aug 25, 2016, 1:04 AM Website Department notifications@github.com wrote:

The problem occurred when I clicked on Woocommerce in the left menu bar and that took me straight to embeds.shopify.com.

I don't know if this helps, but in terms of plugin installation, initially, I installed and activated the Shopify plugin. Then I deactivated that and installed and activated the Woocommerce plugin.

When I discovered your plugin to connect the two I installed and activated it, but it told me that I needed both Woocommerce and Shopify plugins active. I reactivated the Shopify plugin and then activated your plugin.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/secretpizzaparty/shopify-connect-for-woocommerce/issues/24#issuecomment-242310374, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP4nV_uPIeXJVhAbNVOlqH_RaGH6yHUks5qjUx3gaJpZM4JrEwy .

jkudish commented 8 years ago

Seems like the Shopify plugin sometimes sets the url to embeds.shopify.com and embeds.myshopify.com other times. Adding an exception for both.