search

sector-f / failoverd

Scriptable daemon for updating routes based on packet loss to endpoints
MIT License
1 stars 0 forks source link

variable name could be improved #5

Closed kirjavascript closed 1 year ago

kirjavascript commented 1 year ago

https://github.com/sector-f/failoverd/blob/672ed3011898df9287a34ca04b264988bc411f2b/main.go#L27

I suggest 'pinger' please let me know what you think thanks

sector-f commented 1 year ago

Per Practical Go, "Short variable names work well when the distance between their declaration and last use is short."

Given that p is the primary focus of the main function, and that the main function is not very long, I am not convinced that the proposed change would actually improve readability.

kirjavascript commented 1 year ago

fair!