search

sectordistrict / intentrace

intentrace is strace with intent, it goes all the way for you instead of half the way. intentrace is currently in beta
MIT License
496 stars 8 forks source link

Enable Link-Time Optimization (LTO) #1

Closed zamazan4ik closed 2 weeks ago

zamazan4ik commented 2 weeks ago

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Via enabling LTO in the Cargo.toml file we can deliver an LTO-optimized versions of the tool to users with cargo install. Using ThinLTO should also help to reduce the build-time overhead with LTO. E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I have made quick tests (Fedora 40) by adding lto = true to the Release profile. The binary size reduction is from 1.8 Mib to 1.5 Mib.

Thank you.

sectordistrict commented 2 weeks ago

I agree, no harm in adding LTO for release builds. Appreciate the writing, you can create a PR and I'll merge

zamazan4ik commented 2 weeks ago

I agree, no harm in adding LTO for release builds. Appreciate the writing, you can create a PR and I'll merge

Just did it ;) https://github.com/sectordistrict/intentrace/pull/2