Closed sergeyvfx closed 6 years ago
Thanks for your contribution. Where did you got that version of cpplint? I'll have a check and publish a new version.
I'm using latest version from google's styleguide: https://github.com/google/styleguide/tree/gh-pages/cpplint
I have check the patch and cpplint, it does not work. The cpplint which is coming from https://github.com/google/styleguide/tree/gh-pages/cpplint, is not a working one for this plugin, it have lots of different with pip installed cpplint, not only the things you mentioned.
The pip installed cpplint is an enhanced one , which is from https://github.com/cpplint/cpplint, some styles have been outdated(lastest commit date is two years ago). You may do some incorporations with this repository to implement what you want.
Interesting, didn't realize pip's version is using different project.
Oh well, think out of all the alternatives think easiest one is to just me using proper cpplint for this extension.
Do you think it'll make sense to update readme to state that Google's thing is not compatible? That way folks like me who is using Google's tools for years wouldn't get confused like me? :)
P.S. Closing this patch.
There where few issues:
Newer cpplint have
cpplint
after severity word, this was breaking regex.Something in the message parsing was also incompatible with latest cpplint, that part is redone now.
Hopefully still works with older version of script.
Example of the newer script output:
/path/to/file.cc(32): error cpplint: [runtime/explicit] Single-parameter constructors should be marked explicit. [5]