secularbird / cpplint-extension

vscode cpplint extension
MIT License
22 stars 12 forks source link

Fix regex to work with latest cpplint script #18

Closed sergeyvfx closed 6 years ago

sergeyvfx commented 6 years ago

There where few issues:

Hopefully still works with older version of script.

Example of the newer script output:

/path/to/file.cc(32): error cpplint: [runtime/explicit] Single-parameter constructors should be marked explicit. [5]

secularbird commented 6 years ago

Thanks for your contribution. Where did you got that version of cpplint? I'll have a check and publish a new version.

sergeyvfx commented 6 years ago

I'm using latest version from google's styleguide: https://github.com/google/styleguide/tree/gh-pages/cpplint

secularbird commented 6 years ago

I have check the patch and cpplint, it does not work. The cpplint which is coming from https://github.com/google/styleguide/tree/gh-pages/cpplint, is not a working one for this plugin, it have lots of different with pip installed cpplint, not only the things you mentioned.

  1. vs7 logout has change
  2. recursive is not supported
  3. c and some other file extensions is not supported
  4. does not have --repository= and some other arguments

The pip installed cpplint is an enhanced one , which is from https://github.com/cpplint/cpplint, some styles have been outdated(lastest commit date is two years ago). You may do some incorporations with this repository to implement what you want.

sergeyvfx commented 6 years ago

Interesting, didn't realize pip's version is using different project.

Oh well, think out of all the alternatives think easiest one is to just me using proper cpplint for this extension.

Do you think it'll make sense to update readme to state that Google's thing is not compatible? That way folks like me who is using Google's tools for years wouldn't get confused like me? :)

P.S. Closing this patch.