secure-77 / Perlite

A web-based markdown viewer optimized for Obsidian
https://perlite.secure77.de/
MIT License
967 stars 81 forks source link

support for embedded YouTube videos #121

Open rsubr opened 4 months ago

rsubr commented 4 months ago

Thanks for this wonderful project. I am effortlessly publishing my notes online in docker using Gitea webhooks.

Obsidian supports embedding YouTube videos using the same images markdown syntax. Perlite does not support this feature and incorrectly renders YouTube videos as images - none of the YouTube videos are loading. Obsidian Publish renders YouTube links correctly.

Obsidian YouTube Markdown

![Making a Minecraft Obsidian Block in Real Life Using Astro Tech Resin](https://www.youtube.com/watch?v=NnTvZWp5Q7o)

Incorrect Perlite Rendering as IMG

Perlite does not support this and YouTube videos are rendered using an img tag like this:

<img src="https://www.youtube.com/watch?v=NnTvZWp5Q7o"
    alt="Making a Minecraft Obsidian Block in Real Life Using Astro Tech Resin"
    class="external-link perlite-external-link" target="_blank" rel="noopener noreferrer">

Obsidian Publish Rendering as IFRAME

The html used by Obsidian Publish for embedding YouTube is this:

<iframe class="external-embed mod-receives-events"
    sandbox="allow-forms allow-presentation allow-same-origin allow-scripts allow-modals allow-popups"
    allow="fullscreen"
    frameborder="0"
    src="https://www.youtube.com/embed/NnTvZWp5Q7o">
</iframe>

Please note that in Obsidian also recognizes the below forms and the iframe is generated correctly:

![](https://www.youtube.com/watch?v=NnTvZWp5Q7o)

![](https://www.youtu.be/NnTvZWp5Q7o)

![](https://youtu.be/NnTvZWp5Q7o)

Can we please get support for Obsidian YouTube links?

Thanks again for the great project!

secure-77 commented 4 months ago

Thanks for the feedback and this well prepared issue! ❤️

This should be doable 👍 I will try to implement it for the next release!