search

secure-remote-password / srp.net

SRP-6a protocol implementation for .NET Standard 1.6+ and .NET Framework 3.5+
https://www.nuget.org/packages/srp
MIT License
64 stars 10 forks source link

Reuse `ComputeB` function rather for code reuse. #17

Closed mrhappyasthma closed 2 years ago

mrhappyasthma commented 2 years ago

A helper function already exists for computing B, so rather than doing it from scratch, just reuse that.

codecov-commenter commented 2 years ago

Codecov Report

Merging #17 (ada35f5) into master (2730c89) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   89.50%   89.50%   -0.01%     
==========================================
  Files          38       38              
  Lines        4278     4277       -1     
  Branches      148      148              
==========================================
- Hits         3829     3828       -1     
  Misses        394      394              
  Partials       55       55
Impacted Files Coverage Δ
src/srp.tests/SrpServerTests.cs 100.00% <100.00%> (ø)
src/srp/SrpServer.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2730c89...ada35f5. Read the comment docs.

yallie commented 2 years ago

Thank you!