search

secure-remote-password / srp.net

SRP-6a protocol implementation for .NET Standard 1.6+ and .NET Framework 3.5+
https://www.nuget.org/packages/srp
MIT License
64 stars 10 forks source link

Support custom hashes in browser and less than netstandard1.6 #22

Closed jdluzen closed 1 year ago

jdluzen commented 1 year ago

For an upcoming project I needed to support SRP and SHA3 in Blazor WASM. Unfortunately, CryptoConfig is unavailable in the browser. This adds another registration layer for custom hashes. I didn't want to change the public API and force a major version bump. Open to suggestions on alternatives.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 47.05% and project coverage change: -0.17 :warning:

Comparison is base (8e65c3c) 89.47% compared to head (6b801f2) 89.31%.

:exclamation: Current head 6b801f2 differs from pull request most recent head 36c03c0. Consider uploading reports for the commit 36c03c0 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #22 +/- ## ========================================== - Coverage 89.47% 89.31% -0.17% ========================================== Files 38 39 +1 Lines 4277 4294 +17 Branches 149 151 +2 ========================================== + Hits 3827 3835 +8 - Misses 394 401 +7 - Partials 56 58 +2 ``` | [Impacted Files](https://app.codecov.io/gh/secure-remote-password/srp.net/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secure-remote-password) | Coverage Δ | | |---|---|---| | [src/srp.tests/SrpHashTests.cs](https://app.codecov.io/gh/secure-remote-password/srp.net/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secure-remote-password#diff-c3JjL3NycC50ZXN0cy9TcnBIYXNoVGVzdHMuY3M=) | `100.00% <ø> (ø)` | | | [src/srp/CryptoConfig.cs](https://app.codecov.io/gh/secure-remote-password/srp.net/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secure-remote-password#diff-c3JjL3NycC9DcnlwdG9Db25maWcuY3M=) | `38.46% <38.46%> (ø)` | | | [src/srp/SrpHash.cs](https://app.codecov.io/gh/secure-remote-password/srp.net/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=secure-remote-password#diff-c3JjL3NycC9TcnBIYXNoLmNz) | `96.49% <75.00%> (-1.63%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

yallie commented 1 year ago

Great! Thank you! :)