search

secure-remote-password / srp.net

SRP-6a protocol implementation for .NET Standard 1.6+ and .NET Framework 3.5+
https://www.nuget.org/packages/srp
MIT License
68 stars 10 forks source link

Added interfaces for the SrpClient and SrpServer, #9. #9

Closed JarneVanAerde closed 4 years ago

JarneVanAerde commented 4 years ago

Hi,

I'm actively using this package. However, the SrpServer and SrpClient cannot be mocked when testing, because they don't have an interface.

I've added intefaces for those two classes.

Thanks for creating this library!

codecov-commenter commented 4 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          38       38           
  Lines        4255     4255           
  Branches      171      171           
=======================================
  Hits         3807     3807           
  Misses        390      390           
  Partials       58       58
Impacted Files Coverage Δ
src/srp/SrpClient.cs 100.00% <ø> (ø)
src/srp/SrpServer.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c17985...b58db90. Read the comment docs.

yallie commented 4 years ago

Thank you! :)