search

secure-software-engineering / phasar

A LLVM-based static analysis framework.
Other
933 stars 140 forks source link

Draft: Fix RPATH for install #590

Closed fabianbs96 closed 1 year ago

fabianbs96 commented 1 year ago

The install does not install libraries into ${CMAKE_INSTALL_PREFIX}/lib/phasar, but directly into ${CMAKE_INSTALL_PREFIX}/lib. So, the linker rpath should point there as well

vulder commented 1 year ago

@MMory What is the desired location when you package phasar? The RPATH should be correct, however, I'm not sure if you want to directly install into lib, so I'll just wanted to point that out.

MMory commented 1 year ago

For testing, I have set CMAKE_INSTALL_PREFIX to /opt/phasar. When doing so, all of phasars libs are installed to /opt/phasar/lib64, but the schema validator is installed to /opt/phasar/lib. The RPATH is set to /opt/phasar/lib64, leaving the schema validator unresolved. lib seems to be hardcoded on the schema validator side. @fabianbs96 what do you think we should do?

fabianbs96 commented 1 year ago

Thanks @MMory for that info. That is indeed an issue. I marked this PR as draft again, as it seems there is more work to be done. We should also think about whether it is a good idea to install external dependencies at all