search

secure-software-engineering / phasar

A LLVM-based static analysis framework.
Other
919 stars 140 forks source link

added descriptions to TaintConfigSchema.json to explain its semantics #644

Closed StamesJames closed 11 months ago

StamesJames commented 11 months ago

I started playing around with phasar a bit to look if I can use it on llvm code created by rust. At first I have used the analysis-config wrong so I wrote some descriptions into the schema. Maybe this can help future users too and I hope my descriptions are right.

MMory commented 11 months ago

Hi @StamesJames , thank you for your contribution. I have committed a minor change, making all the first letters of the description text capitals. Do you agree with that? If so, I'll merge.

StamesJames commented 11 months ago

Sounds good, thanks :-) I also wrote some notes while playing around with PhASAR which almost are tutorials for using the basics of phasar-cli. I could contribute those too but if I understand it right I can't make a pullrequest for the wiki repo where your other tutorials are. should I just put them in an issue?

MMory commented 11 months ago

Would be good to have those tutorials, thank you! Yeah, an issue might be the best way.

Regarding this PR, the parentheses in line 22 break the build, I have not found an obvious way to escape them, maybe omitting them is the best way to go forward.

StamesJames commented 11 months ago

ah ok thanks for fixing this. And I will write the tutorial and put in in an Issue :-)