search

secure-software-engineering / phasar

A LLVM-based static analysis framework.
Other
919 stars 140 forks source link

killAllFlows() does not kill fact? #681

Closed yuffon closed 7 months ago

yuffon commented 7 months ago

Hi, it seems that killAllFlows() does not kill facts.

https://github.com/secure-software-engineering/phasar/blob/5ddab3f2ebfb7b289657937928ba45eb95cbf9fe/include/phasar/DataFlow/IfdsIde/FlowFunctions.h#L427

The old deprecated version is OK: https://github.com/secure-software-engineering/phasar/blob/5ddab3f2ebfb7b289657937928ba45eb95cbf9fe/include/phasar/DataFlow/IfdsIde/FlowFunctions.h#L1123

Is this a bug?

fabianbs96 commented 7 months ago

Hi @yuffon, yes that looks like a copy-paste error. Thank you!

fabianbs96 commented 7 months ago

This issue has been fixed