search

secure-systems-lab / dsse

A specification for signing methods and formats used by Secure Systems Lab projects.
https://dsse.dev
Apache License 2.0
66 stars 18 forks source link

Add "design requirements" section. #15

Closed MarkLodato closed 3 years ago

MarkLodato commented 3 years ago

This helps readers understand what problems we are trying to solve and why we chose these particular decisions. It also helps us assess potential future changes.

NOTE: The "multi-message file format" is not yet in the spec. I am adding it here because we do need to eventually define that.

trishankatdatadog commented 3 years ago

Mark, should we add backwards-compatibility as a design requirement? As it is right now, I do not see how the spec helps older clients and repositories who cannot immediately upgrade their code.

MarkLodato commented 3 years ago

No. I just responded on #14. Instead of adding backwards compatibility here, I plan to remove it entirely from the spec.

MarkLodato commented 3 years ago

Friendly ping. Ready to merge?

adityasaky commented 3 years ago

@MarkLodato Whoops, sorry! I meant to ask you about:

MUST support multiple signed messages in a single file, possibly as a separate file format

Could you elaborate on the motivating use cases there? Thanks!

Apart from that, it looks good to me, and I'm happy to merge.

MarkLodato commented 3 years ago

Removed. I'll create a separate GitHub issue for this, and we can add the requirement back once we agree and start work on that piece.