feat: move the encrypted package to go-sslib

secure-systems-lab / go-securesystemslib

Cryptographic and general-purpose routines for Golang Secure Systems Lab projects at NYU

MIT License

20 stars 21 forks source link

feat: move the encrypted package to go-sslib #50

Closed rdimitrov closed 11 months ago

rdimitrov commented 11 months ago

Description The following PR moves the encrypted package from go-tuf to go-sslib along with its tests.

Once this PR is merged, we can then proceed with deprecating it from go-tuf and updating its dependants.

Reasoning

The encrypted package in go-tuf provides the functionality to encrypt/decrypt a given byte stream with another.

This is not relevant to the goal of the project and TUF in general. As a result, there are now projects which have go-tuf as their dependency only because of that.

In that sense, I think it would be right if this package is gradually deprecated here and moved to another project which better suits its functionality.

Reference

https://github.com/theupdateframework/go-tuf/issues/476

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 5508699479

111 of 140 (79.29%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 84.848%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
encrypted/encrypted.go	111	140	79.29%
<!--	Total:	111	140	79.29%	-->

Totals
Change from base Build 5478934575:	-1.6%
Covered Lines:	532
Relevant Lines:	627

💛 - Coveralls

adityasaky commented 11 months ago

Thanks for submitting this! I agree that this belongs here. I know it's a move-this-code PR but do you know if it'd be a lot of work to update the tests to just use the stdlib and testify for consistency with the other packages in this module? We then wouldn't have to introduce gopkg.in/check.v1.

rdimitrov commented 11 months ago

Thanks for submitting this! I agree that this belongs here. I know it's a move-this-code PR but do you know if it'd be a lot of work to update the tests to just use the stdlib and testify for consistency with the other packages in this module? We then wouldn't have to introduce gopkg.in/check.v1.

Thanks for the tip! 💯That made a lot of sense!

I've pushed an update where I've refactored the tests accordingly so it no longer uses check.v1 👍

adityasaky commented 11 months ago

Released here: https://github.com/secure-systems-lab/go-securesystemslib/releases/tag/v0.7.0