search

secure-systems-lab / securesystemslib

Cryptographic and general-purpose routines for Secure Systems Lab projects at NYU
MIT License
48 stars 49 forks source link

VaultSigner test unexpectedly does not depend on environment variables #888

Open NicholasTanz opened 1 month ago

NicholasTanz commented 1 month ago

Description of the changes being introduced by the pull request:

Fixes: #820

NicholasTanz commented 1 month ago

Hi @jku, I'm running into an issue where the test-vault.yaml workflow is stuck on the run tests step. I think it may be due to me not setting the VAULT_ADDR envvar properly. Any input is appreciated, thanks

jku commented 1 month ago

I have to admit I know very little about vault or the test setup here. @kairoaraujo might have more to say here?

kairoaraujo commented 1 month ago

I have to admit I know very little about vault or the test setup here. @kairoaraujo might have more to say here?

Added to my TODO. I will have a look.