search

secureCodeBox / documentation

This repo contains the complete SCB project documentation.
https://docs.secureCodeBox.io
9 stars 11 forks source link

Added "Powered by Netlify" to footer #262

Closed Ilyesbdlala closed 2 years ago

Ilyesbdlala commented 2 years ago

Closes https://github.com/secureCodeBox/documentation/issues/260

Signed-off-by: Ilyes Ben Dlala ilyes.bendlala@iteratec.com

netlify[bot] commented 2 years ago

Deploy Preview for docs-securecodebox ready!

Name Link
Latest commit 2f07fdad70d4948fab90caf10710250dc2a4b8dd
Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/62a1c924178c7000089cb75f
Deploy Preview https://deploy-preview-262--docs-securecodebox.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

J12934 commented 2 years ago

Netlify docs say it has to be a link: https://www.netlify.com/legal/open-source-policy/

Ilyesbdlala commented 2 years ago

Netlify docs say it has to be a link: https://www.netlify.com/legal/open-source-policy/

* Must feature a link to our service on your main page, or all internal pages. You have two options:

  * We have [premade badges](https://www.netlify.com/press/#badges) for your convenience, or
  * You may create your own link, which should read “This site is powered by Netlify”, and include a link back to our home page.

Applied the change.

J12934 commented 2 years ago

I guess Data Protection wise pulling the image directly from netlify.com is fine as we are already hosting the site on netlify? Or should we move the image to our repo and host it from our domain, just to be sure? @malexmave do you maybe have a option on that?

malexmave commented 2 years ago

The "cleaner" version would be to host it ourselves, I guess, since this doesn't trigger a 3rd party request on every page load. Less for the actual difference in privacy in case Netlify turns malicious, and more for the load time / complexity. Or we simply go with the plain text version and avoid the image alltogether.

Ilyesbdlala commented 2 years ago

I guess Data Protection wise pulling the image directly from netlify.com is fine as we are already hosting the site on netlify? Or should we move the image to our repo and host it from our domain, just to be sure? @malexmave do you maybe have a option on that?

As a point of reference, This is also how Docusaurus implements this on their website. https://github.com/facebook/docusaurus/blob/main/website/docusaurus.config.js#L559-L564