Closed corrupt closed 1 year ago
netlify[bot]
commented
1 year ago | Name | Link |
|---|---|
| Latest commit | 54bb2d918082b4402490a777418029bd3b2136c1 |
| Latest deploy log | https://app.netlify.com/sites/docs-securecodebox/deploys/63bd916b389bdb0009646e58 |
corrupt
commented
1 year ago I honestly don't understand why the checks fail. It's not in anything I changed but in docs/architecture/09_architecture_decisions where index.md links local files that don't exist in main. And more specifically, in one file that isn't even linked (adr_0017.md).
Ilyesbdlala
commented
1 year ago Hello, Thank you for contribution ! :) I am however confused with what you mean by "installing from helm in 2023" ? We currently use the Bitnami minio helm chart. It requires the use of root-user/root-password. The change was deliberate, as can be seen in the following PRs:
Can you please clarify ?
Ilyesbdlala
commented
1 year ago Hello, Thank you for contribution ! :) I am however confused with what you mean by "installing from helm in 2023" ? We currently use the Bitnami minio helm chart. It requires the use of root-user/root-password. The change was deliberate, as can be seen in the following PRs:
* [Upgraded embedded minio chart to latest release v11.9.4 (closes #755) #1340 ](https://github.com/secureCodeBox/secureCodeBox/pull/1340) * [ fix(minio): Fixed port forward script to fit change to bitnami minio charts #1401 ](https://github.com/secureCodeBox/secureCodeBox/pull/1401)Can you please clarify ?
In review, we realized that even though the SCB v4.0.0 is still not released, we have updated our docs prematurely to fit the changes (oops). We use bitnami minio charts in v4, and we're planning to release it soon. So I'll close this PR without merging. Thank you for letting us find out a mistake in our release process :)
Adapted the instructions to the situation found when installing from helm in 2023.
Signed-off-by: corrupt corrupt@users.noreply.github.com