secureCodeBox / scanner-webapplication-zap

Part of the deprecated secureCodeBox v1, see secureCodeBox/secureCodeBox Repo for v2
Apache License 2.0
6 stars 4 forks source link

Container crashes if wrapper starts before zap proxy #32

Closed J12934 closed 5 years ago

J12934 commented 5 years ago

When the Spring Boot wrapper starts before the zap proxy completes its startup the entire container crashes. Stack trace can be found in the integration suite log: https://travis-ci.com/secureCodeBox/secureCodeBox/builds/99466049#L942

Currently the container only contains a sleep, which should ensure that zap is properly started before the wrapper starts. This is unfortunately not true for all machines especially machines with limited performance. A better way to check it would be a tool like wait-for-it.sh to ensure that zap is up and running before starting the wrapper, or to implement a retry mechanisms for the ZAP Service.

J12934 commented 5 years ago

Closed by #33