Closed RKNF404 closed 1 month ago
Checked with Vanadium. See the issue for partitioning, I guess I misunderstood. Seems like it will be true eventually, since it isn't stable yet? Not sure. Seems worth keeping an eye on. As for :visited link partitioning, it's being consider. I'll close this PR, since there isn't much to add.
@RKNF404 I think we can still add the visited partitioning? https://github.com/GrapheneOS/Vanadium/issues/568#issuecomment-2241199384
Add it before Vanadium? Or do we want to stay synced with Vanadium patches?
We can add it before. We don't have to stay "synced" per se but we can give them a heads up when we find stuff that's common between the two projects
Ok, just wanted to gage your position on that. Do you want to reopen this then and remove the uneeded patches?
I'll get to this Sunday evening (EST), currently without computer.
@RKNF404 for sure! it's foss, there's no rush :smile:
Only one patch should be added here for :visited link partitioning. Vanadium did enable it as well, but they are essentially the same patch.
I opted to avoid scoped memory cache for now, I'll read more about it later.
@RKNF404 yeah makes sense, can you add it to the spec patch as well and then I'll merge this, thanks
Alright, I think that should work now?
Alright, I think that should work now?
almost, you included the patch but didn't set it to run. See line 250
Ok, I believe this is it right?
looks good. can you also set:
Release: 3%{?dist}
then i'll merge and rebuild
Release has been incremented
Enables some partitioning features, relating to memory cache and :visited link databases. Also updates the Vanadium partitioning patch, since most of the features it enables don't exist anymore.