Closed RKNF404 closed 2 months ago
Thanks for reviewing these even though it's all experimental
I agree with you and will make the changes
@RKNF404 On second look, I'll keep the install verifier as-is. If users still want to configure the flag, they should be able to. The goal here is to change the default behavior with no flag provided. I'll make the change for content verifier though.
For the patch
set-default-extension-content-verification-enforce-strict.patch
, the way it is currently done it will only apply if the commandline parameter is passed with no arguments or an unrecognized one. It would be better to replace the final return value in that same function fromstd::max(experiment_value, cmdline_value)
withVerifyInfo::Mode::ENFORCE_STRICT
. Similarly, forset-default-extension-install-verification-enforce-strict.patch
, it overrides the default return value in theGetCommandLineStatus()
function which will work but can be ignored if the commandline parameter is used with another value. Replacing the final return for theGetStatus()
function instead would be better since it will always returnVerifyStatus::ENFORCE_STRICT
if you replacestd::max(GetExperimentStatus(), GetCommandLineStatus())
with it.