search

securedeveloper / react-data-export

Export dataset in react.
https://securedeveloper.github.io/react-data-export/
MIT License
179 stars 194 forks source link

Typescript definitions for components #64

Open daugsbi opened 6 years ago

daugsbi commented 6 years ago

Suggestion:

I would like to use this library in a typescript project. I tried to type the index.js file, but I couldn't find a way to express the export definitions in typescript. So I changed the index.js file, but this would be a breaking change in the API. In addition I exported the react component with the existing typings and referenced the types in the package.json.

Please let me know if you would accept a pull request, which introduces breaking changes or if you have any idea how to correctly type index.js.

My reason:

I would like to use this library with typescript.

Steps to reproduce:

Check the changes in the fork. https://github.com/daugsbi/react-data-export

securedeveloper commented 6 years ago

Hi @daugsbi,

Thank you for deciding to participate to this library, and sorry for the delayed response as I was on summer vacations,

You are welcome to submit a PR and I will review it on my priority,

Br,

harry-sm commented 6 years ago

Yes Please!

securedeveloper commented 5 years ago

@daugsbi can you please submit your pull request, I had a chance to look at your code and it seems good to me, thanks.