search

securefederatedai / openfl

An Open Framework for Federated Learning.
https://openfl.readthedocs.io/en/latest/index.html
Apache License 2.0
734 stars 207 forks source link

Removing the Python Native API #1153

Closed tanwarsh closed 6 days ago

tanwarsh commented 1 week ago

Deprecate Python API:

  1. Mark Python native API as deprecated in the doc
  2. Remove Python native API code.
  3. Remove github workflow realted code.
  4. Remove test related to Python native API.
  5. Remove Tutorials related to Python native API.

This PR will be merged after discussion on FETS Chanllenge as mentioned by Kevin in https://github.com/securefederatedai/openfl/pull/1143#issuecomment-2476567671

tanwarsh commented 1 week ago

@teoparvanov @vrancurel I can still see pipelines and code related to interactive API. Will this be removed? These 3 pipelines are failing as these interactive api code is using python native API. eg code in openfl/openfl/interface/interactive_api/*

teoparvanov commented 1 week ago

@teoparvanov @vrancurel I can still see pipelines and code related to interactive API. Will this be removed? These 3 pipelines are failing as these interactive api code is using python native API. eg code in openfl/openfl/interface/interactive_api/*

Hi @tanwarsh, thanks for refreshing the PR. Could you please remove the failing Interactive API examples from the CI also?

tanwarsh commented 1 week ago

@teoparvanov @vrancurel I can still see pipelines and code related to interactive API. Will this be removed? These 3 pipelines are failing as these interactive api code is using python native API. eg code in openfl/openfl/interface/interactive_api/*

Hi @tanwarsh, thanks for refreshing the PR. Could you please remove the failing Interactive API examples from the CI also?

I have removed the dependency on python native API in openfl/openfl/interface/interactive_api.

teoparvanov commented 1 week ago

Thanks @tanwarsh ! Let's freeze this PR for the time of the 1.7 release (we now have a good understanding of the "blast radius" of removing the Python Native API).

As discussed offline, the next step is to produce a new, more conservative PR where you would:

tanwarsh commented 6 days ago

Closing the PR as this will be merged later. Will create another PR to deprecate Python Native API.