search

securefolderfs-community / SecureFolderFS

Powerful, secure, modern way to keep your files protected.
MIT License
180 stars 14 forks source link

iOS handler issues #71

Open r-work opened 2 weeks ago

r-work commented 2 weeks ago

Description

Secondary toolbar item dissapears when navigating away from page.

To Reproduce

  1. Create a detail page with secondary toolbar item.
  2. Create another page (lets call it page 2) with two secondary toolbar items.
  3. Run app.
  4. Detail page toolbar item appears correctly.
  5. Navigate to page 2, toolbar items appear as text.
  6. Close page 2, (should go back to detail page) now toolbar item dissapears on detail page.

Evidence

No response

App Version

1.0

OS Version

17.6.1

Diagnostic information

No response

d2dyno1 commented 2 weeks ago

Will look into it soon 👀

d2dyno1 commented 2 weeks ago

After some research, I came to a conclusion that rolling out a custom ToolbarItems property on the inherited ContentPage would be better.

  1. More options when setting item icon beyond just ImageSource (a good point to be made can be MauiIcons that pull icons from the font file)
  2. Item states (like checked/unchecked, disabled, etc)
  3. Nesting of menu items, section splitters, section titles:
    iOS UIMenu Screenshot

IMG_0108

A good inspiration for the nesting of items would be to take from WinUI's MenuFlyoutItem* API. In terms of Android, a fallback could be used to the builtin ContentPage.ToolbarItems using OnPlatform (unless there's a specific need for more options. I currently haven't worked on porting it to Android)

Let me know what you think @r-work

r-work commented 2 weeks ago

Sounds good if it's not a massive amount of work. Still hoping that MAUI team will be resolving the issue, though that might be a while. Thanks for all your work.