Closed Rgvs closed 2 months ago
I would also recommend to rebase this since there are some updates in the main. Thanks
Thanks for quick feedback. The analyzerslist.go code i wrote is technically a copy of rulelist.go. Some of your comments would deviate from rulelist.go. In view of that, would you still like me to go ahead and make those changes?
The analyzerslist.go code i wrote is technically a copy of rulelist.go. Some of your comments would deviate from rulelist.go. In view of that, would you still like me to go ahead and make those changes?
Please go ahead. It's fine they don't need to be identical. These are anyhow small things. Thanks for addressing my comments!
Is this fixing #1175 issue?
Yes, but partly.
Allows to exclude analyzers using -exclude
option in cmd line.
This does not fix skipping code by comments like // #nosec G602
Addressed the Comments. Please Re-review. Thank you.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 60.86957%
with 27 lines
in your changes missing coverage. Please review.
Project coverage is 67.15%. Comparing base (
18135b4
) to head (889dcf0
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
cmd/gosec/main.go | 0.00% | 27 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fixes #1175