search

securesauce / precaution-beta

Precaution provides a simple, automated code review for GitHub projects by running code linters with a security focus on pull requests.
Other
1 stars 0 forks source link

Remove redundant second package manager - yarn #208

Closed MVrachev closed 5 years ago

MVrachev commented 5 years ago

From the start of the development of Precaution we are using two package managers - yarn and npm. This is meaningless given that one of them is enough. This situation brings both complexities and sometimes build failures and other problems.

Examples when we update package.json but not yarn.lock and that resolves in build failures:

It will be better to use npm because npm is distributed with Node.js - which means that when you download Node.js, you automatically get npm installed on your computer.

Another reason is that most of the dependencies we are adding are npm modules and thus it makes sense to use npm to handle them.

Closes: https://github.com/vmware/precaution/issues/190

PS: I tried to remove all instances of yarn. If you see any other please let me know.

Signed-off-by: Martin Vrachev mvrachev@vmware.com

MVrachev commented 5 years ago

LGTM. Nit: Start putting Closes: # at the bottom of the commit message, not the top.

Done.