search

securesauce / precaution-beta

Precaution provides a simple, automated code review for GitHub projects by running code linters with a security focus on pull requests.
Other
1 stars 0 forks source link

Disable Mergify automatic merges #217

Closed joshuagl closed 5 years ago

joshuagl commented 5 years ago

Note: I've deleted the Mergify app following the steps in Deleting a GitHub App but that wasn't enough, Mergify is still showing on this PR

We ran into issues with Mergify where our GitHub Pages aren't automatically built and PRs and commits with Fixes or Closes tags don't automatically close the associated Issues.

This is due to a branch protection mechanism on GitHub which prevents merges from bot accounts triggering Pages builds (and presumably closing Issues).

We've discussed this with Mergify upstream: https://github.com/Mergifyio/mergify-engine/issues/386

Unfortunately until upstream resolve this issue Mergify isn't a viable solution for Precaution.

Closes: #205

Signed-off-by: Joshua Lock jlock@vmware.com

MVrachev commented 5 years ago

Typo in commit and pr messages:

Unfortunately ntil upstream resolve this issue Mergify isn't a viable solution for Precaution.

should be until.

joshuagl commented 5 years ago

Typo in commit and pr messages:

Unfortunately ntil upstream resolve this issue Mergify isn't a viable solution for Precaution.

should be until.

Good catch, thanks. I really need to figure out how to get flyspell working on macOS (or switch editor)