securesauce / precaution-beta

Precaution provides a simple, automated code review for GitHub projects by running code linters with a security focus on pull requests.

Other

1 stars 0 forks source link

Add doc for exclude option + globs #222

Closed MVrachev closed 4 years ago

MVrachev commented 5 years ago

Related to pull request https://github.com/vmware/precaution/pull/213 which has to be merged first.

We need documentation for the exclude option and how a user can user globs.

Signed-off-by: Martin Vrachev mvrachev@vmware.com

MVrachev commented 5 years ago

We should merge first pull request number 213 before this one. We don't want to have a doc for a feature we don't currently support.

ericwb commented 5 years ago

There is no need to put "which has to be merged first." in PR message bodies. If there is a dependency, create the dependency using a git rebase.

ericwb commented 5 years ago

"We need documentation for the exclude option and how a user can user globs." - This statement is strange. It sounds as if this is an issue, not a fix.

MVrachev commented 5 years ago

I updated my pr with the suggestion from @joshuagl about the Glob syntax in the exclude option.

MVrachev commented 5 years ago

I updated my pr with the last suggestions from @joshuagl https://github.com/vmware/precaution/pull/222#discussion_r310164822.

codecov-io commented 5 years ago

Codecov Report

Merging #222 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #222   +/-   ##
======================================
  Coverage    98.3%   98.3%           
======================================
  Files          18      18           
  Lines         353     353           
  Branches       38      38           
======================================
  Hits          347     347           
  Misses          6       6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f19bf88...38817b1. Read the comment docs.