search

securesauce / precaution-beta

Precaution provides a simple, automated code review for GitHub projects by running code linters with a security focus on pull requests.
Other
1 stars 0 forks source link

TypeScript filter potentially will match files without ".ts" ending #224

Closed ericwb closed 5 years ago

ericwb commented 5 years ago

Describe the bug See https://github.com/vmware/precaution/blob/master/linters/tslint.js#L29

The filter is looking for "ts" instead of ".ts". Thus that could match with "tests" or any file name ending with "ts"

To Reproduce Code inspection

Expected behavior Expect the filter to be ".ts"

Screenshots n/a

Additional context n/a

MVrachev commented 5 years ago

Fixed by: https://github.com/vmware/precaution/pull/225