search

securesauce / precaution-beta

Precaution provides a simple, automated code review for GitHub projects by running code linters with a security focus on pull requests.
Other
1 stars 0 forks source link

Fix filename extensions in config.fileExtensions to have preceding '.' #236

Closed joshuagl closed 5 years ago

joshuagl commented 5 years ago

Some of file extensions were listed in the fileExtensions array with a preceding '.' and others were not. We must be consistent in using the '.' prefix to all file extensions in the array, otherwise we may have unexpected behaviours such as the filterData() function in github_api_helper.js matching all filenames that end with 'js' or 'ts'.

Signed-off-by: Joshua Lock jlock@vmware.com

MVrachev commented 5 years ago

Good catch!