search

securesauce / precaution-beta

Precaution provides a simple, automated code review for GitHub projects by running code linters with a security focus on pull requests.
Other
1 stars 0 forks source link

Support repeatable deployment in a container #247

Closed joshuagl closed 5 years ago

joshuagl commented 5 years ago

We would like to be able to run Precaution in a container. This series implements a set of changes to enable us to do so in a repeatable fashion.

  1. Switches to Yarn package manager - this enables us to deterministically install our Node dependencies (If our dependencies aren't deterministic we can't reliably produce equivalent runtimes as part of our container build process).
  2. Sets our baseline Node version to 10, as it's available in more distributions we might consider using as a base (i.e. Debian Buster and Photon OS 3.0)
  3. Use pip-compile to generate a deterministic and integrity checked list of Python dependencies for Bandit
codecov-io commented 5 years ago

Codecov Report

Merging #247 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #247      +/-   ##
=========================================
+ Coverage    98.3%   98.3%   +<.01%     
=========================================
  Files          18      18              
  Lines         353     355       +2     
  Branches       38      38              
=========================================
+ Hits          347     349       +2     
  Misses          6       6
Impacted Files Coverage Δ
merge_reports.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f19bf88...ac3617b. Read the comment docs.