securesign / secure-sign-operator

Apache License 2.0
3 stars 17 forks source link

Routes should be unique #86

Closed cooktheryan closed 7 months ago

cooktheryan commented 8 months ago

Currently, we could only have one securesign stack deployed per cluster because of the way the routes are defined. For example

kubectl  get routes -n securesign
NAME                 HOST/PORT                                                          PATH   SERVICES       PORT     TERMINATION     WILDCARD
fulcio-9v6b7         fulcio.apps.rosa.npfiv-awys9-ws2.c8bp.p3.openshiftapps.com         /      fulcio         80-tcp   edge/Redirect   None
rekor-server-wq698   rekor-server.apps.rosa.npfiv-awys9-ws2.c8bp.p3.openshiftapps.com   /      rekor-server   80-tcp   edge/Redirect   None
tuf-8jlq7            tuf.apps.rosa.npfiv-awys9-ws2.c8bp.p3.openshiftapps.com            /      tuf            tuf      edge/Redirect   None
osmman commented 7 months ago

It should be resolved by https://github.com/securesign/secure-sign-operator/pull/107

cooktheryan commented 7 months ago

@osmman i had just pulled main and was looking at this

            host = fmt.Sprintf("%s.%s.%s", svc.Name, svc.Namespace, ctrl.Status.Domain)
        } else {
            host = svc.Name + ".local"
        }

I thought I was losing my mind