search

securesign / sigstore-ocp

sigstore helm-charts and build scripts opinionated for running on OCP and RHEL
Apache License 2.0
13 stars 19 forks source link

feat(config): add rekor endpoint env var #205

Closed kahboom closed 7 months ago

kahboom commented 7 months ago

This PR adds the required environment variable in order for the rekor-search-ui to be able to issue requests to the Rekor server.

Original PR: https://github.com/securesign/sigstore-ocp/pull/204

Testing with the following container image for the rekor search UI: quay.io/kahboom/rekor-search-ui@sha256:68a21610cd7de9c34466fed181fb3b26e527906e194f90657ab3c785b2151c85

Instructions for testing: https://gist.github.com/kahboom/3294d64b5186b3c79b68bd78923ebec5

kahboom commented 7 months ago

I've added some instructions for testing the PR, hopefully it helps as I didn't previously share the container image for rekor-search-ui I had been using (sorry!): https://gist.github.com/kahboom/3294d64b5186b3c79b68bd78923ebec5#file-sigstore-ocp-md

JasonPowr commented 7 months ago

@kahboom The CI is currently failing with:

Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "sigstore" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading scaffold from repo https://sigstore.github.io/helm-charts
Deleting outdated charts
Linting chart "trusted-artifact-signer => (version: \"0.1.46\", path: \"charts/trusted-artifact-signer\")"
Checking chart "trusted-artifact-signer => (version: \"0.1.46\", path: \"charts/trusted-artifact-signer\")" for a version bump...
Old chart version: 0.1.46
New chart version: 0.1.46
Error: failed linting charts: failed processing charts

------------------------------------------------------------------------------------------------------------------------
 ✖︎ trusted-artifact-signer => (version: "0.1.46", path: "charts/trusted-artifact-signer") > chart version not ok. Needs a version bump! 
------------------------------------------------------------------------------------------------------------------------
failed linting charts: failed processing charts
Error: Process completed with exit code 1.

Any time there is a change to the helm chart we need to bump the chart version by one: https://github.com/securesign/sigstore-ocp/blob/main/charts/trusted-artifact-signer/Chart.yaml#L36 so this should become: version: 0.1.47

JasonPowr commented 7 months ago

@kahboom The changes themselves seem fine, works well :), just that small issue with the chart version

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, kahboom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/securesign/sigstore-ocp/blob/main/OWNERS)~~ [JasonPowr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment