search

securespider / pe

0 stars 0 forks source link

Edited json file is not displayed in the app #17

Open securespider opened 1 year ago

securespider commented 1 year ago

To reproduce: copy over past json file back into the data directory

Expected: data should sync with the application

Actual: Data is not displayed in the application

SS: image.png

nus-pe-script commented 1 year ago

Team's Response

Reasoning is the same as the bug on deleting of JSON file

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Deleting Json file does not clear the address book

To reproduce: Delete json file

Expected: Deleting json file changes the delivery list

Actual: Delivery list still stays

SS:

image.png

[original: nus-cs2103-AY2223S2/pe-interim#1269] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This works as intended, as Bookopedia was not relaunched. As shown in the SS below, if tester was to follow the steps correctly by launching Bookopedia only AFTER the changes to JSON data file, it would work as intended.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Other issue is about deleting the json file this is about editing the json file. I realised that deleting the file is actually not a "feature" of 1.4, only editing is, so the other issue report has been accepted to be not in scope.
However, this bug is definitely not a duplicate of that issue and certainly in scope considering it is a feature in UG

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Unexpected behaviour of the application which affects users if they were to edit the json file. Revisiting the user guide to give evidence, ![image.png](https://raw.githubusercontent.com/securespider/pe/main/files/f9f0d364-bfc2-4b50-b4ea-85abd6017206.png)
No where mentioned the need to reload the application to reach the desired outcome. Instructions for advanced users were to "update data directly"
Note that the screenshot and explanation given by the developers is found in the DG which is not accessible to users and me during the product testing phase, so as a user it was a bug that cannot be resolved