securespider / pe

0 stars 0 forks source link

Address level is not limited #9

Open securespider opened 1 year ago

securespider commented 1 year ago

To reproduce: add n/Yusofa a/a #1099 p/6590909 Expected: Error should be thrown - no building is above level 1099 Actual: this is allowed SS:

image.png

nus-se-bot commented 1 year ago

Team's Response

The following statement is just an assumption:

no building is above level 1099

Additionally, this is an expected behavior, where the input is allowed as the address does not limit the floor.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Actually not an assumption but a verifiable statement with a quick google. Anyways, no building exists currently with more than 200 levels. Regardless, there should be some limitations with the address if not someone can put some bogus address unintentionally or to mess with the product. Alternatively, it can be written in the user guide to be careful with the address because there is no height/floor limitations with addresses.

image.png
There should be some sort of limitation for the input if not the user could input random values.
Consider changing to not in scope